Skip to content

Update gh-deploy.yml to remove push triggers #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
a5chin merged 9 commits into from
Jan 11, 2026
Merged

Update gh-deploy.yml to remove push triggers #156

a5chin merged 9 commits into from
Jan 11, 2026
+207 −21

Conversation

@a5chin
Copy link
Owner

@a5chin a5chin commented Jan 10, 2026 •
edited by github-actions bot
Loading

User description

Removed push event triggers for gh-deploy workflow.

Type of Change

  • Hotfix
  • Bug Fix
  • Dependency Update
  • Feature
  • Refactor
  • CI/CD
  • Documentation

Related Issues

Breaking Changes

  • No breaking changes
  • API signature changed
  • Configuration changed
  • Behavior changed
  • Dependencies changed
  • Features removed

Checklist

  • Dependencies added/updated
  • New environment variables
  • Performance impact assessed
  • Security implications reviewed
  • Deployment notes

Additional Context

PR Type

Enhancement, CI/CD

Description

  • Removed push triggers from documentation deployment workflow.

  • Integrated SQLFluff into Nox formatting sessions.

  • Enhanced dev container configuration and extensions.

  • Configured SQLFluff ignore rules.

Diagram Walkthrough

flowchart LR
  A[Push Events] -- "Removed trigger for" --> B(Docs Deployment Workflow)
  C[Nox fmt Session] -- "Now includes" --> D(SQLFluff Formatting)
  E[Dev Container] -- "Updated with" --> F(SQLFluff Extension & Config)
Loading

File Walkthrough
Relevant files
Enhancement
noxfile.py
Integrate SQLFluff into Nox formatting and linting descriptions

noxfile.py

  • Updated the description for the fmt session to include SQLFluff.
  • Added logic to the fmt session to run sqlfluff fix . when the
    --sqlfluff argument is provided.
  • Updated the description for the lint session to include SQLFluff.
 +2/-2     
Configuration changes
devcontainer.json
Refine dev container configuration and extensions               

.devcontainer/devcontainer.json

  • Added "remoteUser": "vscode" at the top level of the configuration.
  • Removed the ms-python.vscode-pylance extension from the VS Code
    customizations.
  • Reordered the arguments in the updateContentCommand for consistency.
  • Removed a duplicate "remoteUser": "vscode" entry from the end of the
    file.
 +3/-4     
release-drafter.yml
Update release drafter configuration for features               

.github/release-drafter.yml

  • Changed the labels key to label for the "Features" category.
  • This adjusts the configuration to use a single label for features
    instead of a list.
 +1/-2     
.sqlfluffignore
Add SQLFluff ignore file                                                                 

.sqlfluffignore

  • Added a new file to specify patterns for SQLFluff to ignore.
  • Includes common ignore patterns for various file types and
    directories.
 +196/-0 
Ci/cd
gh-deploy.yml
Remove push triggers from documentation deployment workflow

.github/workflows/gh-deploy.yml

  • Removed the push event trigger entirely from the workflow.
  • The workflow will now only be triggered by pull_request events.
 +0/-12   
Formatting
lint.yml
Fix newline at end of lint workflow file                                 

.github/workflows/lint.yml

  • Removed the \ No newline at end of file marker.
  • This is a minor formatting fix to ensure the file ends with a newline.
 +1/-1     

@a5chin
Update gh-deploy.yml to remove push triggers
a68b09a 
Removed push event triggers for gh-deploy workflow.
@a5chin a5chin self-assigned this Jan 10, 2026
@github-actions github-actions bot added the fix label Jan 10, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2026 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCover
tools/config
   fastapi.py20100%
   settings.py200100%
tools/logger
   color.py120100%
   googlecloud.py60100%
   local.py120100%
   logger.py230100%
   style.py70100%
   type.py50100%
tools/tracer
   timer.py160100%
TOTAL1030100%

Tests Skipped Failures Errors Time
8 0 💤 0 ❌ 0 🔥 1.388s ⏱️

@a5chin a5chin merged commit 4f00511 into main Jan 11, 2026
11 checks passed
@a5chin a5chin deleted the fix/workflow branch January 11, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@a5chin a5chin

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@a5chin